Hi Kevin, On 2026-02-25T17:57:24+0800, Kevin J. McCarthy wrote: > The latest version changes string search functions, such as strchr() > and strrchr(), so that the return type is the same type as the string > passed in. > > This helped us catch a real bug in browser.c (3a8dfafc), and also > turned up some variable type issues, fixed here.
Nice!
>
> Thanks to Rene Kita for the work on the Arch sr.ht build files which
> turned up the bugs, and for an initial patch showing where the warning
> were, which this commit is based upon.
>
> Also thanks to Alejandro Colomar for quickly explaining what was going
> on and helping debug the issues.
You're welcome! :-)
> ---
> mh.c | 6 ++++--
> muttlib.c | 3 ++-
> parse.c | 5 +++--
> rfc1524.c | 7 ++++---
> sendlib.c | 3 ++-
> url.c | 10 ++++++----
> 6 files changed, 21 insertions(+), 13 deletions(-)
>
[...]
Most changes look good.
> diff --git a/parse.c b/parse.c
> index 141947f4..c46a5811 100644
> --- a/parse.c
> +++ b/parse.c
[...]
> @@ -1001,7 +1001,8 @@ time_t mutt_parse_date (const char *s, HEADER *h)
> {
> struct tz_t *tz;
>
> - tz = bsearch (ptz, TimeZones, sizeof TimeZones/sizeof (struct
> tz_t),
> + tz = (struct tz_t *)bsearch (ptz, TimeZones,
> + sizeof TimeZones/sizeof (struct tz_t),
> sizeof (struct tz_t),
> (int (*)(const void *, const void *))
> ascii_strcasecmp
> /* This is safe to do: A pointer to a struct equals
But, why do we need to cast here?
[...]
Have a lovely day!
Alex
--
<https://www.alejandro-colomar.es>
signature.asc
Description: PGP signature
