On Wed, Feb 25, 2026 at 11:43:18AM +0100, Rene Kita wrote:
LGTM! Works in sr.ht CI with one more minor problem, which was not on my list.rfc2047.c: In function ‘try_block’: rfc2047.c:331:5: error: the comparison will always evaluate as ‘true’ for the pointer operand in ‘(const char *)&RFC2047Specials + 13’ must not be NULL [-Werror=address] 331 | assert (strchr (RFC2047Specials, '?')); | ^~~~~~ cc1: all warnings being treated as errors Where RFC2047Specials is defined as const char RFC2047Specials[] = "@.,;:<>[]\\\"()?/= \t"; in line 68 of the same file. Is there anything special about '?' here? As long as no dev drops it from RFC2047Specials this assert will always be true and does not make sense in my eyes. I would drop it in a separate patch when sending the patch for the Arch manifest.
Please go ahead. It was added 26 years ago, but I don't see the purpose.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
