Hi,
* Alain Bench [02-07-15 23:15:53 +0200] wrote:
> On Thursday, July 11, 2002 at 11:24:36 PM +0200, Thorsten Haude wrote:
> > I also see another error, where Mutt displays an empty line between
> > the (correct) GPG output and the marker: '[-- Ende der PGP-Ausgabe
> > --]' and won't verify the mail.
> Happens only, but always, with traditional PGP? Then setting
> $pgp_good_sign correctly should solve it.
I was pointed to bug #856 which makes mutt think a signature
is bad if $pgp_good_sign didn't match. But it cannot match
if it is empty (other regexp implementations return a match
of an empty regexp against a non-empty string; mutt
doesn't). This only affects $pgp_check_traditional which
should be fixed by the attached patch (not by me and
untested but it made into the debian package for mutt). The
bug report was rejected with the hint to set $pgp_good_sign
correctly. But IMO it should work without setting it, too.
bye, Rocco
--- pgp.c-orig Sun Nov 25 15:09:03 2001
+++ pgp.c Sun Nov 25 15:09:08 2001
@@ -384,9 +384,13 @@
rc = pgp_copy_checksig (pgperr, s->fpout);
if (rc == 0)
have_any_sigs = 1;
- if (rc || rv)
+ /* Sig is bad if gpg_good_sign-pattern did not match ||
+ * pgp_decode_command returned not 0
+ * Sig _is_ correct if gpg_good_sign="" && pgp_decode_command
+ * returned 0 */
+ if (rc==-1 || rv)
maybe_goodsig = 0;
}
safe_fclose (&pgperr);
