On Thu, 11 Jan 2007 00:16:29 CST, [EMAIL PROTECTED] wrote: > > On Wed, 10 Jan 2007 20:59:22 CST, stuart wrote: > > Hi GC... > > > > Just wanted to report: I compiled Ozzy's patch and it appears to work. > > I'll try switching to the more probable solution of calling the ulong > > instead of the long function later. Jon, Simon, David and Eric appear > > to be the authors of the effected file (libs/libcmyth/socket.c) - so > > I'll let them decide on how to fix this - unless I hear otherwise. > > I think it's wrong to change cmyth_rcv_long(). If myth is trying to > send an unsigned long, then we should be interpreting the field as an > unsigned long. If myth is passing an invalid number, then we should > deal with the out of range error in cmyth_rcv_proginfo(). > > I'll look at the various versions of myth and see whether this should > be a signed value or not. > > Jon
It turns out that channel id is a string. I guess we've been getting lucky all along that it has always been a number. The chanid is not used much in libcmyth or mvpmc, so fixing this should not be too hard. But the correct fix would be to treat it as a string since we appear to have no guarantee that it is a number. Jon ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Mvpmc-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mvpmc-users mvpmc wiki: http://mvpmc.wikispaces.com/
