Follow-up Comment #17, bug #16569 (project mypaint):
I don't think this patch should be applied as it is, or at least not rushed
in for 0.9.0.
I checked the interpolation code itself, and the mathematical approach makes
sense to me and looks correct. (Appart from the x==-1, y==-1 check which
could easily be replaced by a pressure check for -1).
However doing the interpolation in front of _stroke_to() breaks the
workarounds that check for dtime (eg. when the user does nothing for a long
time). Those would have to be moved into the outer function somehow before
the patch can be applied.
A minor point is that it looks a bit silly to have two interpolation rutines,
one linear and one quadratic. Quadratic probably would not be that much slower
to justify this. I suspect it's slower now because it increases the number of
calls to _stroke_to() a lot, which does a lot of setup/teardown work. On the
positive side, interpolation is nicely separated from the brush engine core
this way.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?16569>
_______________________________________________
Nachricht geschickt von/durch Gna!
http://gna.org/
_______________________________________________
Mypaint-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-bugs
