On Thu, Mar 4, 2010 at 9:09 PM, Martin Renold <[email protected]> wrote:
> On Tue, Mar 02, 2010 at 08:43:38PM +0100, Jon Nordby wrote: > > http://gitorious.org/~jonnor/mypaint/jonnors-clone/commits/gui_document > > No objection to the refactoring in there, looking good after a first > glance. > Let's try this. Please fix the performance tests when you push this into > master. > Playing the devils advocate here. One alternative we have here is to not inherit from lib.document.Document, but instead let it have a reference to it, probably self.model It might be better with respect to encapsulation, in the sense that is obvious when you're groping at internals (self.app.doc.model.something). What do you think? -- Regards Jon Nordby - www.jonnor.com
_______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
