On Thu, Mar 04, 2010 at 09:54:12PM +0100, Jon Nordby wrote: > Playing the devils advocate here. One alternative we have here is to not > inherit from lib.document.Document, but instead let it have a reference to > it, probably self.model > It might be better with respect to encapsulation, in the sense that is > obvious when you're groping at internals (self.app.doc.model.something). > What do you think?
We have discussed this before; I am slightly in favour of explicit references instead of inheritance. But it's not a dogma (TiledSurface also uses inheritance), and maybe inheritance works better here. You have given this more thought than me by now, and I don't see anything obviously wrong, either way. If it turns out bad we can change it again later as we learn more. -- Martin Renold _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
