Hi, and first of all hi to all - as this is my first post here, also congratulations to devs for making MyPaint one great tool, yay!
To keep the story short, today I decided to build git version of mypaint - did it - and noticed two small things in current git version that I decided to patch at least for me, and share them. When I find some free time I hope to do some more sniffing around the code as I wasn't reading it yet, for now I only got rid of what I though was not right or annoying and simple to do for the beginning :) So, first thing I noticed was that Refresh and Open Previous Scrap share same hotkey, it doen't sound well that way, right? Other thing is that brush settings window modified to support simple and advanced mode doesn't respect saved information, it always opens in top-left corner if in last session it was closed. Well, at least for me it behaves like that - what seemed right in this situation was changing show_all and set_now_show_all to top-level box instead of window itself, and then it seems it's handled OK (tested it a bit, but didn't had time to do more) What do you think about those? I might overlooked something because as I said I had very little time to spare so I didn't had chance to try stuff out, and just wanted to get it working for now :) cheers, Andrzej.
From 3d239389eb7b7236d124ade4a6b096d678f872fc Mon Sep 17 00:00:00 2001 From: Andrzej Giniewicz <[email protected]> Date: Fri, 14 May 2010 16:16:58 +0200 Subject: [PATCH 1/2] Conflict in default hotkeys. Default hotkeys for "Reload" and "Open Previous Scrap" are same (F5). Because F5 is more obvious for "Reload", F7 is assigned for "Open Previous Scrap" instead of F5. --- gui/filehandling.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gui/filehandling.py b/gui/filehandling.py index 020c103..2c862ef 100644 --- a/gui/filehandling.py +++ b/gui/filehandling.py @@ -40,7 +40,7 @@ class FileHandler(object): ('Save', gtk.STOCK_SAVE, _('Save'), '<control>S', None, self.save_cb), ('SaveAs', gtk.STOCK_SAVE_AS, _('Save As...'), '<control><shift>S', None, self.save_as_cb), ('SaveScrap', None, _('Save As Scrap'), 'F2', None, self.save_scrap_cb), - ('PrevScrap', None, _('Open Previous Scrap'), 'F5', None, self.open_scrap_cb), + ('PrevScrap', None, _('Open Previous Scrap'), 'F7', None, self.open_scrap_cb), ('NextScrap', None, _('Open Next Scrap'), 'F6', None, self.open_scrap_cb), ] ag = gtk.ActionGroup('FileActions') -- 1.7.1
From 029402a74353d1488b06a5d34cbf957fa5c58978 Mon Sep 17 00:00:00 2001 From: Andrzej Giniewicz <[email protected]> Date: Fri, 14 May 2010 16:19:50 +0200 Subject: [PATCH 2/2] Brush settings window doesn't respect saved position and visibility. It's always displayed and always in top-left corner if user have it hidden. To fix this, call show_all and set_no_show_all on windows top level box instead of window itself. --- gui/brushsettingswindow.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gui/brushsettingswindow.py b/gui/brushsettingswindow.py index 4d89761..2818a9c 100644 --- a/gui/brushsettingswindow.py +++ b/gui/brushsettingswindow.py @@ -105,8 +105,8 @@ class Window(windowing.SubWindow): self.relabel_buttons() #self.mode_changed_cb(mode_sel) - self.show_all() - self.set_no_show_all(True) + top_vbox.show_all() + top_vbox.set_no_show_all(True) mode_sel.set_active(0) def mode_changed_cb(self, widget): -- 1.7.1
_______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
