On 21/09/11 15:31, しげっち wrote: > Currently I implemented the some SVG-compatible layer mode > (composite-ops) into the mypaint. > You can see the source code repository at > http://git.sourceforge.jp/view?p=mypaint-anime/master.git > If you have interested in my project, feel free to discuss about it. > I'm also welcome to merge any of my source code into main development > branch if you like it.
This looks very interesting, I'll keep an eye on this with an eye to merging it. Looks like a really nice, useful subset of the SVG blend ops! I'll take others' word that the C++ part of this is correct, but thanks to David for the side-by-side comparison upthread. Just some minor comments: * Cosmetic: putting the composite control alongside the opacity slider makes the layers box cluttered when resized to be very narrow. * Missing functionality: Merge Down isn't implemented, or rather it forces the top layer's mode to the default mode before applying. * Cosmetic: changing blend modes is undoable, but comes up as "Undo Unknown Action" in the menu (my fault for changing how Undo and redo appear recently, I guess! Should be obvious how to fix it.) * Cosmetic: the display names for the ops should be capitalised :) * Workflow: not sure about splitting undo stack strokes at the end of input strokes. This may be more natural for people, but are there any potential technical tripfalls? Maxy? Jon? I'll have a proper play later on, but this seems like the right way of doing blends for both compatibility reasons and because it's closer to what users expect if blends are implmented at all. I must confess I'm not a huge fan of this sort of thing implemented as a modification to the brush - that still seems weird to me. sigetch: many thanks for this, and it looks like a really positive contribution so far! -- Andrew Chadwick _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
