2011/9/22 Andrew Chadwick <[email protected]>: > This looks very interesting, I'll keep an eye on this with an eye to > merging it. Looks like a really nice, useful subset of the SVG blend ops!
Thanks a lot for your quick review and comments. > * Cosmetic: putting the composite control alongside the opacity slider > makes the layers box cluttered when resized to be very narrow. I agree :) To have working example quickly, I chose the simplest way to implement. Current my GUI implementation is very ugly, so it must be refined. > * Missing functionality: Merge Down isn't implemented, or rather it > forces the top layer's mode to the default mode before applying. Well, I implemented the composition function for RGBA over RGBA layer, I expect that merge down function is implemented correctly. However, its behavior is not intuitive so that results of the composition looked weird. According to the SVG compositing spec. (http://www.w3.org/TR/SVGCompositing/ ), If some opaque layer is composited on top of the transparent layer, resulting layer should be opaque, while it results in transparent layer when you use the GIMP and do same composition. I think the way of the current GIMP should be correct, but current behavior of my branch do according to the SVG spec. > * Cosmetic: changing blend modes is undoable, but comes up as "Undo > Unknown Action" in the menu (my fault for changing how Undo and redo > appear recently, I guess! Should be obvious how to fix it.) I see the problem and fix it ;) Thanks. > * Cosmetic: the display names for the ops should be capitalised :) Well, it requires some more hacks to implement, because my GUI implementation is very poor, and internal layer mode identifier data uses the text of the combo box directly. -- sigetch [email protected] _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
