On 4 September 2013 11:47, Andrew Chadwick <[email protected]> wrote:
> On 22 August 2013 22:53, Leonardo Pereira <[email protected]> wrote: > > Hello, just dropping by to say I tried to tidy up the brush editor(and > the > > icon editor) window. They were very small edits. > > > > http://i.imgur.com/KjcBN8C.png > > https://gitorious.org/mypaint/mypaint/merge_requests/21 > > > > That is all, folks. > > Hi Leonardo -- > > I've merged your changes to the icon editor. Thanks! > > Re the brush editor: looks promising; let's discuss: > > I notice your buttons don't have icons, possibly due to the GTK > setting. Your patch makes the icon preview image non-square when icons > are enabled for GTK, but that can be fixed (GtkAspectFrame ftw.) > > This is definitely a GTK setting. > Fully agree with putting the Rename and Edit Icon buttons on the top > row, near the name and the icon (!). Do you think we could make the > icon and the name clickable in some way, or would that make the editor > window less obvious to casual users? > > I guess an example of this is the GNOME Control Center User Accounts panel. Your user icon, name, password, and language appear normal, but show the button frame when you hover over them. I'm not sure if they have a custom widget for it though. > I think Save should be on the bottom right for RTL layout, not on the > bottom left. There's a good reason for this: I'm trying to implement a > diagonal flow to the editor > http://designinginterfaces.com/firstedition/index.php?page=Diagonal_Balance > (which the later edition expanded a bit) with the "what am I doing?" > reminder information at the top left, and the "I'm done now!" final > action buttons at the bottom right. Following the flow of reading for > RTL languages - and GTK+ will flip the layout for LTR languages, so it > works for them too :-) > > I feel like you may have your RTLs and LTRs mixed up here. English is LTR. Yes, we should move Delete away from Edit Icon and/or Save. What about > > * Delete: bottom right > Do you mean left here? > * Rename and Edit Icon: integrate with the icon preview and the name label. > - Make the icon a normal-looking button, and the name "label" a > rollover button, maybe... > * Save: Bottom right > * Copy to New: bottom right, near Save > * Live Update: top right? > > Arguably "Copy as New" is a starting point as well as a finishing > point... :/ I like the idea of having it as a nearby alternative to > "Save", however, because "Save" overwrites the existing brush and is > arguably a destructive action. > > The GNOME HIG (however outdated that may be) has the "most useful" (or let's say, "most likely to be something a user would press") button at the far right, so at the very least, I'd expect Save to be there, and certainly not Delete. > -- > Andrew Chadwick > > On 22 August 2013 22:53, Leonardo Pereira <[email protected]> wrote: > > Hello, just dropping by to say I tried to tidy up the brush editor(and > the > > icon editor) window. They were very small edits. > > > > http://i.imgur.com/KjcBN8C.png > > https://gitorious.org/mypaint/mypaint/merge_requests/21 > > > > That is all, folks. > > > > _______________________________________________ > > Mypaint-discuss mailing list > > [email protected] > > https://mail.gna.org/listinfo/mypaint-discuss > > > > > > -- > Andrew Chadwick > > _______________________________________________ > Mypaint-discuss mailing list > [email protected] > https://mail.gna.org/listinfo/mypaint-discuss > -- Elliott
_______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
