the diff you sent has tabs instead of spaces and incorrect brace positioning. Could you please read the coding guidelines at http://sourceforge.net/docman/display_doc.php?docid=6080&group_id=31650 and re-submit.
Another question I have is about the nantTask paramater passed in to the Solution class's constructor. In your patch you cast this to a SolutionTask instance and then use some properties from it. This works fine now because Solution is only ever instanciated from SolutionTask passing itself in the constructor.
However in that case why is the paramater a Task instance instead of a SolutionTask insance ? Is there an intent to use the solution class from other tasks that require solution functionality ? With these changes Solution will break if somthing other than a SolutionTask is passed to the constructor. The same goes for ConfigurationSettings.
maybe Matt can comment on the intended use of the _nanttask member.
Ian
A couple weeks ago I submitted a patch that added webmap to the solution task and fixed a couple of bugs including the issue in Resource.cs that made resource compilations failed. I just finished getting latest from the anonymous source forge and none of this has been applied. Should I be looking elsewhere?
We identified another bug in the resource compilation of the solution task that I wanted to fix.
Please advise.
-------------------------------------
TFC
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
