Hi Sundar, this is a lower-case review with two minor remarks for Global.java: * in the first chunk, the comment above the deleted line for LAZY_SENTINEL can go away as well * in the last chunk, how about renaming isLocationPropertyPlaceholder() to isUninitialized()?
Otherwise, nothing to add. :-) Best, Michael > Am 07.07.2015 um 12:30 schrieb A. Sundararajan > <sundararajan.athijegannat...@oracle.com>: > > Please review http://cr.openjdk.java.net/~sundar/8130663/ for > https://bugs.openjdk.java.net/browse/JDK-8130663 > > - made 6 fields as static in Global.java > - using lazy init sentinel as location placebolder as well > - few other simple code cleanups. > > Thanks, > -Sundar -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
