+1 Skickat från min iPhone
> 7 jul 2015 kl. 15:02 skrev Attila Szegedi <attila.szeg...@oracle.com>: > > +1. > >> On Jul 7, 2015, at 1:11 PM, A. Sundararajan >> <sundararajan.athijegannat...@oracle.com> wrote: >> >> Updated: http://cr.openjdk.java.net/~sundar/8130663/webrev.01/ >> >> -Sundar >> >>> On Tuesday 07 July 2015 04:31 PM, Hannes Wallnoefer wrote: >>> +1 >>> >>> Nitpick: although 1 << 0 is redundant, we use it in various places and it >>> helps keep declaration of flags consistent, so I'd vote for keeping it. >>> >>> Hannes >>> >>>> Am 2015-07-07 um 12:30 schrieb A. Sundararajan: >>>> Please review http://cr.openjdk.java.net/~sundar/8130663/ for >>>> https://bugs.openjdk.java.net/browse/JDK-8130663 >>>> >>>> - made 6 fields as static in Global.java >>>> - using lazy init sentinel as location placebolder as well >>>> - few other simple code cleanups. >>>> >>>> Thanks, >>>> -Sundar >>> >> >
