Hi Sundar,

> Am 22.08.2015 um 00:38 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> Please review http://cr.openjdk.java.net/~sundar/8134255/ for 
> https://bugs.openjdk.java.net/browse/JDK-8134255


lower-case thumbs up. This is great.

Nits:
* PackagesHelper.java:102, @paraam -> @param
* PackagesHelper.java:136, some arguments missing final

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>     Oracle is committed to developing 
practices and products that help protect the environment

Reply via email to