Re: RFR 8134255: Implement tab-completion for java package prefixes and package names

[Sundararajan Athijegannathan]

Hi Michael,

Thanks for the review. I fixed those and going ahead with push.
PS. Updated webrev for the record: 
http://cr.openjdk.java.net/~sundar/8134255/nashorn/webrev.01/

Thanks,
-Sundar

On 8/22/2015 8:51 PM, Michael Haupt wrote:
Hi Sundar,

Am 22.08.2015 um 00:38 schrieb Sundararajan Athijegannathan 
<sundararajan.athijegannat...@oracle.com>:
Please review http://cr.openjdk.java.net/~sundar/8134255/ for 
https://bugs.openjdk.java.net/browse/JDK-8134255

lower-case thumbs up. This is great.

Nits:
* PackagesHelper.java:102, @paraam -> @param
* PackagesHelper.java:136, some arguments missing final

Best,

Michael