Hi Sundar, lower-case thumbs up.
Best, Michael > Am 08.10.2015 um 08:24 schrieb Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com>: > > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8139106/ for > https://bugs.openjdk.java.net/browse/JDK-8139106 > > Changes: > > * JSONCompatibleTest was in jdk.nashorn.api.scripting test - a package used > in named module jdk.scripting.nashorn. > Moved this to a different package - like other tests this class is in > jdk.nashorn.api.scripting.test package. > > * module exports needed for nasgen and tests [nasgen and test classes are in > unnamed modules] should use "ALL-UNNAMED" rather than blank. > > * build.xml: > 1) compiling only jdk.scripting.nashorn module (leaving 'shell' module of > nashorn) > 2) removed unnecessary -XaddExports > 3) Using -Xpatch... javac option rather than -J-Xpatch... in "compile-test" > > With these changes, I can do "ant clean test" and "ant clean test262parallel" > with jake/nashorn. Couple of test262 issues fail - but that may be due to > missing "whitespace handling fix" that went to jdk9-dev/nashorn recently. And > there are few (internal) javadoc warnings for nashorn code. > > Thanks, > -Sundar -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
