Looks good and builds for me on 9. Are the 262 issues tracked separately? +1
/M > On 08 Oct 2015, at 08:24, Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com> wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8139106/ for > https://bugs.openjdk.java.net/browse/JDK-8139106 > > Changes: > > * JSONCompatibleTest was in jdk.nashorn.api.scripting test - a package used > in named module jdk.scripting.nashorn. > Moved this to a different package - like other tests this class is in > jdk.nashorn.api.scripting.test package. > > * module exports needed for nasgen and tests [nasgen and test classes are in > unnamed modules] should use "ALL-UNNAMED" rather than blank. > > * build.xml: > 1) compiling only jdk.scripting.nashorn module (leaving 'shell' module of > nashorn) > 2) removed unnecessary -XaddExports > 3) Using -Xpatch... javac option rather than -J-Xpatch... in "compile-test" > > With these changes, I can do "ant clean test" and "ant clean test262parallel" > with jake/nashorn. Couple of test262 issues fail - but that may be due to > missing "whitespace handling fix" that went to jdk9-dev/nashorn recently. And > there are few (internal) javadoc warnings for nashorn code. > > Thanks, > -Sundar
