Hi folks, I just now got to review the "8142968: Module System implementation” commit, rather its Nashorn-specific parts. Overall it looks good, I have one small objection: formatting in JavaAdapterBytecodeGenerator seems off, I think some tab characters snuck in.
I also don’t fully understand why Context.java switched from sourceFor(String, URL) to sourceFor(String, InputStream) - is that related to modules at all, or is just an optimization in that Class.getResourceAsStream is more efficient than going through URL.openConnection().getInputStream()? (In any case, I’m fine with it.) Attila.
