Hi Attila, My reply comments below..
On 3/23/2016 8:11 PM, Attila Szegedi wrote: > Hi folks, > > I just now got to review the "8142968: Module System implementation” commit, > rather its Nashorn-specific parts. Overall it looks good, I have one small > objection: formatting in JavaAdapterBytecodeGenerator seems off, I think some > tab characters snuck in. I'll check that and piggyback in my next commit. > > I also don’t fully understand why Context.java switched from > sourceFor(String, URL) to sourceFor(String, InputStream) - is that related to > modules at all, or is just an optimization in that Class.getResourceAsStream > is more efficient than going through URL.openConnection().getInputStream()? > (In any case, I’m fine with it.) URL ClassLoader.getResource(String) method no longer returns URL for resources. http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-December/005672.html javadoc comment in java.lang.ClassLoader: / * Resources in a named module are private to that module. This method does * not find resources in named modules defined to this class loader. / http://hg.openjdk.java.net/jdk9/dev/jdk/file/403329bd6983/src/java.base/share/classes/java/lang/ClassLoader.java So, we had to change to use InputStream instead of URL. Thanks, -Sundar > Attila.
