On 6/17/05, Zoran Vasiljevic <[EMAIL PROTECTED]> wrote: > > Am 17.06.2005 um 12:30 schrieb Zoran Vasiljevic: > > >> > >> I see that quite a lot of plumbing must be done > >> to get this working. We must keep the Sock for > > > > Wrong. Not very many plumbings, as we have almost > all in place. > > The chages would be mainly in the driver.c SockRead() > to declare SOCK_READY at the point of reading maxreadahead > even if there are still bytes left to consume from socket. > > The Ns_ConnContent has to check this fact and go and > fetch the remaining (spooling all thats left in a > mmaped file) before returning the pointer to the > content. > > Ns_ConnClose should respectively do unmapping > of files, if any mapped. Conn structure should be expaned > to hold mmaped file maintenance fields of course.
Sounds like a plan for stage 1. > The NsTclConnObjCmd should get someting like > ns_conn setmaxinput or similar (details can be cleared here). Stage 2... > All in all, it does not seems like too much plumbing > as I anticipated. It would be great to beef up the test suite in this area. This has historicaly been a buggy part of the code base (you found another one just yesterday), which I guess is inevitable: a lot of string processing and complicted sequence of OS calls. If there's any part of the code base we should be testing, it's this.
