Dear Gustav,
Thank you for your mail message.
My answer here below.
Maurizio
-----Original Message-----
From: Gustaf Neumann [mailto:neum...@wu.ac.at]
Sent: 17 October 2012 11:47
To: naviserver-devel@lists.sourceforge.net
Subject: Re: [naviserver-devel] [AOLSERVER] Naviserver Win-64 Sources
Maurizio,
the changes you have done are textually quite large, the patch is 6000 lines
+.
Please, don't expect, we can apply this and forget about it, we need some
time to digest this. Please, don't be impatient, we all have limited time.
For some problems, it seems for me to be better to follow the tcl
conventions, since it is not unlikely, that who ever works on the details of
naviserver will have to deal with the tcl sources as well.
What it makes this also more time consuming is that some of the changes
should be probably done differently, like the cases described below that i
have picked randomly. This list is most like not complete.
all the best
-gustaf neumann
+#ifdef _WIN64
+ Ns_DStringPrintf(dsPtr, "%d %d %d %l64d %l64d %l64d
%l64d",
+#else
Ns_DStringPrintf(dsPtr, "%d %d %d %" PRId64 " %"
PRId64 " %" PRId64 " %" PRId64,
+#endif
question arise: is this just _WIN64 or as well _WIN32?
Why not define PRId64 correctly for _WIN64? (and _WIN32?)
[MM] Because the PRId64 thing works with gcc and not with Visual Studio (or
to be correct I did not manage to make it work). I believe it works if you
use MinGW, so this is why I used only _WIN64
Or, why have you commented out certain code (a) for win64 and (b) for all
platforms which is certain useful:
#ifdef NS_NOCOMPAT
-# error "No compatibility macros at present"
+// # error "No compatibility macros at present"
#endif
This is my error, sorry, should be under _WIN64
...
#ifdef HAVE_TCL_GETMEMORYINFO
- Tcl_GetMemoryInfo(&ds);
- Tcl_DStringResult(interp, &ds);
+ // Tcl_GetMemoryInfo(&ds);
+ // Tcl_DStringResult(interp, &ds);
#endif
return TCL_OK;
same as above under _WIN64
another problem is that there are some fixes included, which have nothing to
do with
_WIN64 and which are fixed already in the tip version on bitbucket.
--- /usr/local/src/naviserver-4.99.4/nsd/compress.c
2010-03-07 17:08:38.000000000 +0100
+++ ./nsd/compress.c 2012-10-13 10:03:54.000000000 +0200
@@ -299,7 +299,11 @@
return;
}
+#ifdef _WIN64
+int
+#else
char *
+#endif
Ns_CompressBufsGzip(Ns_CompressStream *stream, struct iovec *bufs, int
nbufs, int flags,
Ns_DString *dsPtr)
[MM]
That looked to me as an error, but did not dare to correct it. Just correct
the fix and take away the _WIN64 stuff if you believe it is right
----------------------------------------------------------------------------
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics Download AppDynamics Lite for
free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
