> On April 17, 2013, 1:50 a.m., Simeon Bird wrote: > > common/regexpcache.cpp, line 102 > > <http://git.reviewboard.kde.org/r/109991/diff/1/?file=138503#file138503line102> > > > > I'm slow and stupid...could you please comment what it is you are > > trying to do with this function? Ideally you could split it up into some > > smaller functions. > > Lukasz Olender wrote: > Generally it doesn't look good at first glance, but I'm not sure whether > a lot of small functions will make it better. Regexp code and concatenation > of multiple strings often may look ugly. I've added some comments and > splitted first part into two separated functions. Is it better?
That's better, thanks. - Simeon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109991/#review31192 ----------------------------------------------------------- On April 18, 2013, 4:27 p.m., Lukasz Olender wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109991/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 4:27 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > It's related with https://bugs.kde.org/show_bug.cgi?id=303654. > P.S. I accidentally deleted author's and license info in patch. Isolated > performance tests are also uploaded to http://www.sendspace.com/file/mkihdp > (previous link not always work). It's my first patch. > > > This addresses bug 303654. > http://bugs.kde.org/show_bug.cgi?id=303654 > > > Diffs > ----- > > common/regexpcache.h d89f968 > common/regexpcache.cpp df45277 > > Diff: http://git.reviewboard.kde.org/r/109991/diff/ > > > Testing > ------- > > > Thanks, > > Lukasz Olender > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
