----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109991/#review60248 -----------------------------------------------------------
I never landed up applying this patch in Nepomuk. Even though it works perfectly, I was a little troubled by the additional amount of code which one would have to maintain. Now with Qt5, one can use QRegularExpression instead of QRegExp which is much much faster. Based on a simple benchmark, it gives a 10x increase in performance. I'm going to discard this patch now. Sorry :( - Vishesh Handa On May 3, 2013, 11:26 a.m., Lukasz Olender wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/109991/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 11:26 a.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Bugs: 303654 > http://bugs.kde.org/show_bug.cgi?id=303654 > > > Repository: nepomuk-core > > > Description > ------- > > It's related with https://bugs.kde.org/show_bug.cgi?id=303654. > P.S. I accidentally deleted author's and license info in patch. Isolated > performance tests are also uploaded to http://www.sendspace.com/file/mkihdp > (previous link not always work). It's my first patch. > > > Diffs > ----- > > common/regexpcache.h d89f968 > common/regexpcache.cpp df45277 > > Diff: https://git.reviewboard.kde.org/r/109991/diff/ > > > Testing > ------- > > > Thanks, > > Lukasz Olender > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
