> On April 29, 2013, 10:37 a.m., Vishesh Handa wrote: > > common/regexpcache.h, line 67 > > <http://git.reviewboard.kde.org/r/109991/diff/4/?file=140678#file140678line67> > > > > const QString& outerPatten > > Lukasz Olender wrote: > I can't do that since I modify it. Should I create a temporary variable?
Nah. It's cool then. I didn't notice that. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109991/#review31740 ----------------------------------------------------------- On May 3, 2013, 11:26 a.m., Lukasz Olender wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109991/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 11:26 a.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > It's related with https://bugs.kde.org/show_bug.cgi?id=303654. > P.S. I accidentally deleted author's and license info in patch. Isolated > performance tests are also uploaded to http://www.sendspace.com/file/mkihdp > (previous link not always work). It's my first patch. > > > This addresses bug 303654. > http://bugs.kde.org/show_bug.cgi?id=303654 > > > Diffs > ----- > > common/regexpcache.h d89f968 > common/regexpcache.cpp df45277 > > Diff: http://git.reviewboard.kde.org/r/109991/diff/ > > > Testing > ------- > > > Thanks, > > Lukasz Olender > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
