Thanks Chris. I will take your comments into account and push the patch.
- Kurchi
On 4/24/2012 5:46 AM, Chris Hegarty wrote:
Kurchi,
The change looks fine to me. Thanks for forward porting.
Trivially, the indentation of getDefaultScopeID looks a little off.
Specifically, L121 in the new file:
ni_defaultIndexID = (*env)->GetStaticFieldID(env, c,
"defaultIndex", "I");
And indented 5 (one to many) spaces after the closing if bracket.
No need to regenerate the webrev, I'm happy for you to push.
-Chris.
On 23/04/2012 21:46, Kurchi Hazra wrote:
Hi,
Before joining multicast groups with IPv6 addresses on Mac OS, the
network interface to be used should also be set correctly. This
change enables using a default network interface on Mac OS X if no
interface has been specified.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274
Webrev:
http://cr.openjdk.java.net/~khazra/7144274/webrev_jdk8/webrev.00/
This change was originally pushed into 7u4[1], but needs to be pushed
into jdk 8 also. There are no additional changes required for Jdk 8.
Thanks,
Kurchi
[1] >
http://mail.openjdk.java.net/pipermail/net-dev/2012-February/004078.html
--
-Kurchi
