Hi,
under the following link you can find an updated version of my change
where I've fixed all indentation in Inet{4,6}AddressImpl.c to 4 spaces
and changed the few C++-style comments (i.e. '//') to C-style comments
(i.e. '/* */'):
http://cr.openjdk.java.net/~simonis/webrevs/8060470.v2/
Can I please also get a review with regards to the content of this
change (as opposed to its form:)
Thank you and best regards,
Volker
On Mon, Oct 27, 2014 at 7:27 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 27/10/2014 17:45, Volker Simonis wrote:
>>
>> :
>> Well, the problem is that already that very file contains code in both
>> code conventions (see for example the implementations of 'ping4()'
>> and 'Java_java_net_Inet4AddressImpl_isReachable0()' in
>> Inet4AddressImpl.c which are mostly indented by two spaces). I have no
>> problems to adhere to any convention as long as it is generally
>> obeyed. As this does not seemed to be the case in these files, I've
>> just chosen what I thought is most appropriate. So to keep a long
>> story short - I can either:
>>
>> 1. indent my changes to four spaces (which will still let the files
>> with mixed indentation)
>> 2. change all indentation in the file to two spaces
>> 3. change all indentation in the file to four spaces
>>
>> Please just tell me what you'd prefer.
>>
> We normally use 4 space indent in the library code. There are some
> inconsistencies, I don't know the fully history to understand how we got
> 2-space indent but if you can fix it up then that would be great.
>
> -Alan
