thanks Alan,
I'll double check the illegal state token recognition.
There was a security test that used this.
property name of "jdk.net.hosts.file" is fine.
we can remove the code for reading the service provider property
sun.net.spi.nameservice.provider.<N>
and ignore its setting if we think that is most appropriate. I
considered the ServiceConfigurationError, not quite "user friendly", but
a reasonable form of feedback, to convey that the functionality was not
available and so that an application
could be amended to align with NameService retirement.
On 27/10/2015 15:05, Alan Bateman wrote:
On 25/10/2015 23:32, Mark Sheppard wrote:
Hi,
please oblige and review the following changes
http://cr.openjdk.java.net/~msheppar/8134577/webrev/
which address the issue raised in
https://bugs.openjdk.java.net/browse/JDK-8134577
the operative word has been "eliminate".
This has been a very troublesome mechanism so good to see this reduced
down to a hosts file that we can we use for testing.
Shouldn't the reading of sun.net.spi.nameservice.provider.<N> be
removed so that the throwing of ServiceConfigurationError can be
removed too?
Also just on the property name, I would assume it should be something
like "jdk.net.hosts.file" rather than "jdk.internal.hosts".
Do we have tests that are using the illegal_state_exception token? I
didn't spot any in the webrev. Just wondering if this is the right
exception for testing.
-Alan.
