> On 25 Jan 2019, at 17:04, Chris Hegarty <chris.hega...@oracle.com> wrote:
>
> I moved the code to common.Utils, to avoid any unnecessary dependency.
Thanks.
>> 2. Why does this change add server.close() to each and every test method of
>> WebSocketTest? If I'm not mistaken that's what @AfterTest public void
>> cleanup()
>> is supposed to do.
>
> I think @AfterTest does not do what you think it does.
You are right, I was mistaken. I will have to make sure WebSocket test cases
perform their cleanup correctly. Looks like it's not the only test file that
has this issue.
Try-with-resources might be okay and self-contained, true. However, for my
liking it's a bit messy for this purpose. It's a duplication in every method and
eats up one full indentation block. @AfterMethod [1] seems to be the right thing
to do.
--------------------------------------------------------------------------------
[1] http://testng.org/doc/documentation-main.html#annotations
