Daniel,

> On 11 Apr 2019, at 17:15, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
> 
> On 11/04/2019 17:01, Chris Hegarty wrote:
>> Yes, this is a good point. What’s nice about this is that there is just
>> one body of code that provides the functionality ( and it is all in
>> Java, not native). I'm interested to see how this performs in Arthur's
>> experiments, and I need to do a little more testing myself. It is
>> important that a test leaves enough breadcrumbs behind if it decides
>> that it will not run.
> 
> Ah - so possibly we could have a higher level method in IPSupport:
> that would do something like:
> 
> public static void ensureConfigurationIsValid()
>           throws jtreg.SkippedException {
> 
>  if (!IPSupport.currentConfigurationIsValid()) {
>      // log the configuration, provides diagnostic
>      // as to why it is invalid
>      ...
>      String message = "invalid configuration for this test: " + ...;
>      throws new SkippedException(message);
>  }
> 
> }
> 
> Is that what you have in mind Chris?

No, but that looks much better than what was in my head ;-)
I like it Daniel, as its a one line change to the test source.

-Chris.

Reply via email to