On Thu, 20 Jan 2022 11:14:40 GMT, Michael Osipov <d...@openjdk.java.net> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 133:
>
>> 131:
>> (String)env.get(TlsChannelBinding.CHANNEL_BINDING_TYPE));
>> 132: } catch (ChannelBindingException e) {
>> 133: throw new SaslException(e.getMessage(), e);
>
> Why not ust pass the exception if the API allows? This looks like message
> duplication.
Actually, it turns out I should be throwing `NamingException` here. That is
what was being thrown by `TlsChannelBinding.parseType` before and an existing
test was expecting that. NamingException only takes a String message. So, there
won't be a root cause exception.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7065
