On Fri, 21 Jan 2022 15:40:16 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more tidy-up
>
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 144:
>
>> 142: } catch (ChannelBindingException e) {
>> 143: throw new NamingException(e.getMessage());
>> 144: }
>
> Should we call initCause here and above? I see that we do call initCause in
> NegotiatorImpl.java.
> On the one hand it's better for diagnostic. On the other hand it exposes a
> module-internal exception class which is not great. Or maybe we should set
> the cause of the CBE as the cause of NamingException.
As long as the spec has not dictated what the cause should be, I don't care if
the exception type is internal or not.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7065
