On Sat, 30 Apr 2022 09:55:16 GMT, Michael Felt <d...@openjdk.java.net> wrote:

>> with IP "0.0.0.0"
>> 
>> - it either does nothing and ping fails, or, in some virtual environments
>> is treated as the default route address.
>> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted
>> as a vaild psuedo IPv6 address. '::1' must be used instead.
>> 
>> ping: bind: The socket name is not available on this system.
>> ping: bind: The socket name is not available on this system.
>> PING ::1: (::1): 56 data bytes
>> 64 bytes from ::1: icmp_seq=0 ttl=255 time=0.037 ms
>> 64 bytes from ::1: icmp_seq=1 ttl=255 time=0.045 ms
>> 
>> --- ::1 ping statistics ---
>> 2 packets transmitted, 2 packets received, 0% packet loss
>> round-trip min/avg/max = 0/0/0 ms
>> PING ::1: (::1): 56 data bytes
>> 64 bytes from ::1: icmp_seq=0 ttl=255 time=0.052 ms
>> 64 bytes from ::1: icmp_seq=1 ttl=255 time=0.047 ms
>> 
>> --- ::1 ping statistics ---
>> 2 packets transmitted, 2 packets received, 0% packet loss
>> 
>> 
>> A long commit message. 
>> 
>> This came to light because some systems failed with IPv4 (those that passed
>> replaced 0.0.0.0 with the default router. but most just fail - not 
>> substituting
>> 0.0.0.0 with 127.0.0.1. However, InetAddress.getByName("") returns 127.0.0.1
>> which compares well with other platform's behavior.
>
> Michael Felt has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use @requires jtreg tag rather than check in code

test/jdk/java/net/Inet4Address/PingThis.java line 33:

> 31:  * @library /test/lib
> 32:  * @summary InetAddress.isReachable is returning false
> 33:  *          for InetAdress 0.0.0.0 and ::0

Typo: `InetAdress` -> `InetAddress`

test/jdk/java/net/Inet4Address/PingThis.java line 37:

> 35:  *          but does not respond as 127.0.0.1 (i.e., only responds
> 36:  *          when an external device reacts to 0.0.0.0)
> 37:  */

This line should be removed to fix formatting of the comment section, ie 
unbalanced `*/`

-------------

PR: https://git.openjdk.java.net/jdk/pull/7013

Reply via email to