On Thu, 20 Jul 2023 17:39:12 GMT, Vyom Tewari <[email protected]> wrote:
>> Terry Chow has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated copyright year > > src/jdk.net/windows/classes/jdk/net/WindowsSocketOptions.java line 93: > >> 91: private static native boolean getIpDontFragment0(int fd, boolean >> isIPv6) throws SocketException; >> 92: private static native void setTcpkeepAliveProbes0(int fd, int value) >> throws SocketException; >> 93: private static native int getTcpkeepAliveProbes0(int fd) throws >> SocketException; > > there is inconsistency in function naming some place you use 'keep' and other > places you use 'Keep', can you please make it consistence ?. Fixed inconsistency. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14232#discussion_r1269842252
