> Can I please get a review of this change which removes unused code from 
> `sun.net.www.protocol.jar.URLJarFile` and removes 
> `sun.net.www.protocol.jar.URLJarFileCallBack`?
> 
> As noted in the linked issue https://bugs.openjdk.org/browse/JDK-8323645 the 
> `sun.net.www.protocol.jar.URLJarFileCallBack` was relevant and used only by 
> Java Plugin code (the "deploy" module in JDK 8) which hasn't been in the JDK 
> for several releases now. Effectively this interface and its sole usage in an 
> internal class of the JDK has been a leftover.
> 
> The commit in this PR removes that leftover code. No new tests have been 
> added, given the nature of this change. tier1, tier2, tier3 continue to pass 
> with this change.

Jaikiran Pai has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains two additional commits since the 
last revision:

 - merge latest from master branch
 - 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack 
interface

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17396/files
  - new: https://git.openjdk.org/jdk/pull/17396/files/a7bfb6b4..80dd62a7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17396&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17396&range=00-01

  Stats: 5328 lines in 70 files changed: 3154 ins; 1838 del; 336 mod
  Patch: https://git.openjdk.org/jdk/pull/17396.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17396/head:pull/17396

PR: https://git.openjdk.org/jdk/pull/17396

Reply via email to