On Fri, 12 Jan 2024 13:56:51 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which removes unused code from > `sun.net.www.protocol.jar.URLJarFile` and removes > `sun.net.www.protocol.jar.URLJarFileCallBack`? > > As noted in the linked issue https://bugs.openjdk.org/browse/JDK-8323645 the > `sun.net.www.protocol.jar.URLJarFileCallBack` was relevant and used only by > Java Plugin code (the "deploy" module in JDK 8) which hasn't been in the JDK > for several releases now. Effectively this interface and its sole usage in an > internal class of the JDK has been a leftover. > > The commit in this PR removes that leftover code. No new tests have been > added, given the nature of this change. tier1, tier2, tier3 continue to pass > with this change. This pull request has now been integrated. Changeset: 9d1a6d14 Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/9d1a6d14846bb1f76ca7258452b3b3f8e3e8b223 Stats: 118 lines in 2 files changed: 1 ins; 91 del; 26 mod 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack interface Reviewed-by: alanb, dfuchs ------------- PR: https://git.openjdk.org/jdk/pull/17396
