On Thu, 25 Apr 2024 08:09:28 GMT, Christoph Langer <[email protected]> wrote:
>> The test case sun/net/www/http/HttpClient/KeepAliveTest.java could be more >> effective. >> >> It tests a matrix of HTTP client settings and server behavior, resulting in >> 160 individual test scenarios. Each is tested in an own freshly spawned JVM >> via the `@run main/othervm` directive. The need for new VMs is due to the >> fact that the behavior of the HTTP client is determined at VM initialization >> and can not be changed later on. However, for each distinct type of client >> settings, one VM can be reused. This would lead us from 160 JVM >> instantiations down to 16 which has a factor 10 influence on test runtime. >> >> E.g. on my developer laptop runtime went down from ~100s to ~10s. >> >> I also made additional cleanups/refactoring in the test. > > Christoph Langer has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Merge branch 'master' into JDK-8330523 > - Review Feedback Daniel > - Merge branch 'master' into JDK-8330523 > - Simplify the test further > - Merge branch 'master' into JDK-8330523 > - Small further cleanup > - JDK-8330523 LGTM. Thanks! ------------- Marked as reviewed by djelinski (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18817#pullrequestreview-2021828068
