On Thu, 25 Apr 2024 11:59:56 GMT, Christoph Langer <[email protected]> wrote:

>> The test case sun/net/www/http/HttpClient/KeepAliveTest.java could be more 
>> effective.
>> 
>> It tests a matrix of HTTP client settings and server behavior, resulting in 
>> 160 individual test scenarios. Each is tested in an own freshly spawned JVM 
>> via the `@run main/othervm` directive. The need for new VMs is due to the 
>> fact that the behavior of the HTTP client is determined at VM initialization 
>> and can not be changed later on. However, for each distinct type of client 
>> settings, one VM can be reused. This would lead us from 160 JVM 
>> instantiations down to 16 which has a factor 10 influence on test runtime.
>> 
>> E.g. on my developer laptop runtime went down from ~100s to ~10s.
>> 
>> I also made additional cleanups/refactoring in the test.
>
> Christoph Langer has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Use platform thread for server instead of virtual. Seems to be faster

Marked as reviewed by djelinski (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18817#pullrequestreview-2022700508

Reply via email to