On Fri, 10 Apr 2026 16:37:45 GMT, Daniel Fuchs <[email protected]> wrote:
>> Hi, may I get a review for this change that convert some more java/net tests >> from TestNG to JUnit. >> >> In order to avoid a bigger changeset that would be harder to review, this >> batch simply changes all TestNG tests under java/net that have either URL or >> Http in their names. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Review feedback > - Merge branch 'master' into junit-url-http-8381767 > - Merge branch 'master' into junit-url-http-8381767 > - Merge branch 'master' into junit-url-http-8381767 > - Merge branch 'master' into junit-url-http-8381767 > - Merge branch 'master' into junit-url-http-8381767 > - 8381767: Refactor various java/net/*[URL/Http]*/ TestNG tests to use JUnit Marked as reviewed by vyazici (Reviewer). test/jdk/java/net/URLConnection/RequestProperties.java line 60: > 58: urls.add("ftp://foo:[email protected]/etc/passwd";); > 59: } > 60: return List.copyOf(urls); Nice simplification. _Nit:_ I doubt if this `copyOf` needed at all. ------------- PR Review: https://git.openjdk.org/jdk/pull/30626#pullrequestreview-4096956615 PR Review Comment: https://git.openjdk.org/jdk/pull/30626#discussion_r3071389868
