On Mon, 13 Apr 2026 07:14:17 GMT, Volkan Yazici <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits since the last revision:
>>
>> - Review feedback
>> - Merge branch 'master' into junit-url-http-8381767
>> - Merge branch 'master' into junit-url-http-8381767
>> - Merge branch 'master' into junit-url-http-8381767
>> - Merge branch 'master' into junit-url-http-8381767
>> - Merge branch 'master' into junit-url-http-8381767
>> - 8381767: Refactor various java/net/*[URL/Http]*/ TestNG tests to use JUnit
>
> test/jdk/java/net/URLConnection/RequestProperties.java line 60:
>
>> 58: urls.add("ftp://foo:[email protected]/etc/passwd";);
>> 59: }
>> 60: return List.copyOf(urls);
>
> Nice simplification. _Nit:_ I doubt if this `copyOf` needed at all.
Not really needed - I just prefer to return an immutable list if possible.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30626#discussion_r3072029339
