On Tue, 11 Aug 2026 11:03:43 GMT, Daniel Fuchs <[email protected]> wrote:

>> Lee Jiwon has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8308183: Convert the regression test to JUnit and update the bug tag
>
> test/jdk/java/net/httpclient/Http1RequestEmptyBufferTest.java line 115:
> 
>> 113:                     null);
>> 114:             HttpClient client = HttpClient.newBuilder()
>> 115:                     .proxy(HttpClient.Builder.NO_PROXY)
> 
> Ideally we should use try-with-resources here too to make sure the client is 
> closed when no longer needed

Thanks for the review. Addressed in 05284b363e2cc4755e91a31459be34c66c772d30

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32209#discussion_r3763051241

Reply via email to