On Wed, 12 Aug 2026 14:23:36 GMT, Daniel Fuchs <[email protected]> wrote:
>> Lee Jiwon has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8308183: Use try-with-resources for HttpClient
>
> test/jdk/java/net/httpclient/Http1RequestEmptyBufferTest.java line 95:
>
>> 93: throw new IOException("Unexpected EOF while reading terminal
>> chunk");
>> 94: } catch (SocketTimeoutException e) {
>> 95: return terminalChunkCount;
>
> The caveat is that this test will always have to wait for
> Utils.adjustTimeout(1000) before the full response is received. Well, I guess
> that can't be helped.
If the server sends `Connection: close` and the test reads until EOF, the
response is no longer delayed by the socket timeout on the normal path.
The timeout is still kept as a backstop.
With the JDK-8308024 fix reverted, 20/20 runs failed with `got: 2`. With the
fix in place, 30/30 runs passed.
I haven't pushed this change yet. Would you prefer this approach?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32209#discussion_r3772227120
