On Sat, 19 Sep 2026 12:24:49 GMT, David Carlier <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add 8392732 to @bug of the test
>
> src/java.base/unix/native/libnet/net_util_md.c line 418:
>
>> 416: #ifdef MACOSX
>> 417: /* macOS stores linger values as signed shorts in the kernel. */
>> 418: if (level == SOL_SOCKET && opt == SO_LINGER) {
>
> I wonder why `SO_LINGER_SEC` had not been used on mac throughout, which is
> the true equivalent of other platforms `SO_LINGER` (SO_LINGER on mac works on
> ticks as units not seconds). But that would a breaking change in another hand.
Unfortunately it was implemented as ticks in the original BSD/macOS port in JDK
7u and hasn't been re-visited. It's probably so far to set SO_LINGER that it
hasn't been noticed, at least not until a few days ago when it surfaced while
looking at the changes behavior in macOS 27. So I think it will be future work
to move to seconds.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32961#discussion_r4053289219
