On Sat, 19 Sep 2026 13:35:28 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add 8392732 to @bug of the test
>
> test/jdk/java/net/Socket/SetSoLinger.java line 59:
>
>> 57: try (Socket s = new Socket(ss.getInetAddress(),
>> ss.getLocalPort());
>> 58: // accept the connection
>> 59: Socket accepted = ss.accept()) {
>
> The "accept the connection" comment ends up between two conditions so hard to
> see where the end of the resource is, so I think drop that line.
Done, i've removed that comment and spaced out the first line in that
try-with-resources block to make it a bit more clear where the resources end.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32961#discussion_r4053431251
