On Fri, 2 Oct 2026 19:20:21 GMT, Sean Mullan <[email protected]> wrote:
>> Artur Barashev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 11 commits: >> >> - Merge branch 'master' into JDK-8388519 >> >> # Conflicts: >> # src/java.base/share/classes/sun/security/ssl/Finished.java >> - Address review comments. Update ImmutableExtendedSSLSession. >> - TLSv1.2 uses ephemeral elliptic-curve key exchange by default >> - Repurpose unused NamedGroup.namesOf() method >> - Minor test changes >> - Test improvements >> - More unit tests >> - Add SSLSocket unit test >> - Restore recordEvent signature >> - Code re-arrangement >> - ... and 1 more: https://git.openjdk.org/jdk/compare/39f3ef1b...d4add784 > > src/java.base/share/classes/javax/net/ssl/SSLSocket.java line 886: > >> 884: * Specification, and may also include other named groups that the >> provider >> 885: * supports. >> 886: * > > Suggest adding an API Note (and an `@see` label) telling users how to get the > list of enabled named groups, ex: "To get the names of the named groups which > are currently enabled for use on this connection, call > `getSSLParameters().getNamedGroups()`" > > Same comment for `SSLEngine` and `SSLServerSocket`. Done, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4185745290
