On Mon, 5 Oct 2026 15:34:17 GMT, Artur Barashev <[email protected]> wrote:
>> Main changes: >> - Adding `(SSLEngine | SSLSocket | >> SSLServerSocket).getSupportedNamedGroups()` public API methods. >> - Adding `ExtendedSSLSession.getNamedGroup()` public API method. >> >> Additional side-issues being addressed: >> - Repurpose currently unused NamedGroup.namesOf() method >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Update javadocs src/java.base/share/classes/sun/security/ssl/NamedGroup.java line 437: > 435: > 436: static String[] namesOf(List<NamedGroup> groups) { > 437: return groups.stream().map(ng -> ng.name).toArray(String[]::new); Can `groups` or `ng` ever be `null` as in the prior code? src/java.base/share/classes/sun/security/ssl/NamedGroup.java line 437: > 435: > 436: static String[] namesOf(List<NamedGroup> groups) { > 437: return groups.stream().map(ng -> ng.name).toArray(String[]::new); Did you consider the prior log message unnecessary or too noisy for some reason? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4187735968 PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4187753640
