On Sat, Sep 4, 2010 at 4:51 PM, Wes Hardaker <[email protected]
> wrote:
>
> (note to Bart: we're in "voting mode" for release candidates on the
> trunk right now. Which means no one should be touching trunk without
> discussion -coders first please. Thanks!)
>
> Bart already applied this patches which means:
>
> 1) if it doesn't get +3 it will be reverted
> 2) we need to decide if it's worth it to publish a rc3 because of it
> (and another):
>
> However the patch gets +1 for me, though I probably wouldn't hold up 5.6
> for it just to do another rc3.
>
> --- trunk/net-snmp/include/net-snmp/library/snmpTLSBaseDomain.h 2010/09/04
> 06:37:23 19371
> +++ trunk/net-snmp/include/net-snmp/library/snmpTLSBaseDomain.h 2010/09/04
> 06:38:19 19372
> @@ -77,7 +77,7 @@
> struct snmp_session *sess);
> int tls_get_verify_info_index(void);
>
> - void *netsnmp_tlsbase_free_tlsdata(_netsnmpTLSBaseData *tlsbase);
> + void netsnmp_tlsbase_free_tlsdata(_netsnmpTLSBaseData *tlsbase);
> #ifdef __cplusplus
> }
> #endif
> --- trunk/net-snmp/snmplib/transports/snmpTLSBaseDomain.c 2010/09/04
> 06:37:23 19371
> +++ trunk/net-snmp/snmplib/transports/snmpTLSBaseDomain.c 2010/09/04
> 06:38:19 19372
> @@ -772,7 +772,7 @@
> return tlsdata;
> }
>
> -void *netsnmp_tlsbase_free_tlsdata(_netsnmpTLSBaseData *tlsbase) {
> +void netsnmp_tlsbase_free_tlsdata(_netsnmpTLSBaseData *tlsbase) {
> if (!tlsbase)
> return;
>
The commit message of this change was:
------------------------------------------------------------------------
> r19372 | bvassche | 2010-09-04 08:38:19 +0200 (Sat, 04 Sep 2010) | 3 lines
> Fixed a compiler warning that was introduced in r19356 by changing the
> return
> type of netsnmp_tlsbase_free_tlsdata() from void* to void.
>
I
This change is safe because this function is new and its "return value"
isn't used anywhere.
Bart.
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
