On Tue, Mar 22, 2011 at 9:53 PM, Magnus Fromreide <[email protected]>wrote:
> On 2011-02-23 01:06, Wes Hardaker wrote:
>
>>
>> A massive patch that implements the following feature:
>>
>> http://www.net-snmp.org/wiki/index.php/Feature_Marking_and_Selection
>>
>> is being committed at the moment. Michael Baer (baerm) and I have been
>> working on it for about 3 months or longer in an offline git
>> repository. Originally I was hoping we could commit it in smaller
>> chunks, but 'git svn' really doesn't like merges, branches and trees
>> just like Dorothy doesn't. So, it's going in as a huge commit (at least
>> it'll be easy to reverse if need be).
>>
>
> I have just written my first feature, in part inspired by bug #3234754, and
> I came to the following problems:
>
> * How should features that affect the ABI/API be handled?
> * Looking at REMOVE_STATISTICS it seems it is ok to include the feature
> header from a .h file, is that correct?
>
> Does anyone have any other comments on it?
>
My two cents: if the ABI or API depends on whether a feature is enabled or
disabled, we do no longer have an ABI nor an API. This conflicts with what I
have learned about how to define a shared library or DLL ABI or API. So
removal of fields from structures or adding/removing arguments to functions
should go through the normal mechanism: only make such changes between
releases and not in a release itself or via the feature mechanism.
Bart.
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
