On 4/2/2020 8:44 AM, Glenn Holmer wrote:
On 4/2/20 9:45 AM, Ernie Rael wrote:
On 4/2/2020 7:25 AM, Glenn Holmer wrote:
On 4/2/20 9:08 AM, Ernie Rael wrote:
On 4/2/2020 6:31 AM, Geertjan Wielenga wrote:
I propose we keep things short and sweet for JavaFX in NetCAT 12.0:
https://netbeans-vm.apache.org/synergy/client/app/#/specification/452
There are four cases: IDE-JDK-version (8, 11+) vs JavaFX-version (8,
11+). In beta2 jdk8 is a mess with error badges and failed compiles.
With recent NB and archetype changes, which are in master and so should
be in beta3, all four combos should work cleanly.
What about profiling? I haven't been able to get that to work (JDK 11),
although it does work using VisualVM as an external profiler.
I think https://github.com/apache/netbeans/pull/2021 fixes profiling in
many cases (nothing fx specific), but it's hung up in how to build it.
After a profiling attempt, nbactions.xml has javafx: targets for run and
debug, while profile has org.codehaus.mojo:exec-maven-plugin. That's
like what run and debug originally had that didn't work, isn't it?
I've got in nbactions
<action>
<actionName>profile</actionName>
<goals>
<goal>clean</goal>
<goal>javafx:run@ide-profile</goal>
</goals>
<properties>
<vm.args>${profiler.args} -classpath
%classpath</vm.args>
</properties>
</action>
and then an execution
<execution>
<!-- Configuration for automatic IDE
profiling -->
<id>ide-profile</id>
<configuration>
<options>
<option>${vm.args}</option>
</options>
<mainClass>com.raelity.play.xs13.App</mainClass>
</configuration>
</execution>
But this doesn't quite work. For one thing that "%classpath" is probably
a windows thing that would normally be "$classpath"; I don't thing this
is a big problem, it may not even be needed.
The big problem from my perspective is around
"<option>${vm.args}</option>". This is getting treated as a single
string, instead of a space separated list of options. For example, my
test case value of ${vm.args} is (much longer):
-XX:+HeapDumpOnOutOfMemoryError
-XX:HeapDumpPath=F:\tmp\DummyModule\build\te...
and I get this error
Unrecognized VM option 'HeapDumpOnOutOfMemoryError
-XX:HeapDumpPath=F:\tmp\DummyModule\build\te...'
Notice how it's quoted. Perhaps there is a maven way to split this string?
BTW, if I manually copy the string into <option>copy the vmargs</option>
then the profiler seems to work.
If there's no maven way to do this, I'll file an issue with the openjfx
guys and see if they have any ideas.
-ernie
---------------------------------------------------------------------
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
