Re: Fw: [Bug 5050] New: KERNEL: assertion (cnt <= tp->packets_out) failed at net/ipv4/tcp_input.c (1476)

[Herbert Xu]

On Sat, Aug 13, 2005 at 10:41:20AM +0200, pstaszewski wrote:
>
> ok i applied this patch and debug show:
> 
> packets_out = 16, fackets_out = 5, reordering = 3, sack_ok = 0x3, 
> mss_cache=1460

Doh! I got the if statement wrong in the debugging patch so instead
of printing things out when the bug strikes it's doing the exact
opposite.

Please revert it and apply this one instead.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1474,6 +1474,10 @@ static void tcp_mark_head_lost(struct so
        int cnt = packets;
 
        BUG_TRAP(cnt <= tp->packets_out);
+       if (unlikely(cnt > tp->packets_out)) {
+               printk("packets_out = %d, fackets_out = %d, reordering = %d, 
sack_ok = 0x%x, mss_cache=%d\n", tp->packets_out, tp->fackets_out, 
tp->reordering, tp->rx_opt.sack_ok, tp->mss_cache);
+               dump_stack();
+       }
 
        sk_stream_for_retrans_queue(skb, sk) {
                cnt -= tcp_skb_pcount(skb);